New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ModalFooter): count children properly #3790
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mainframev
force-pushed
the
fix/modal-footer
branch
from
March 28, 2023 14:19
d44a1bb
to
353306f
Compare
Deploying with Cloudflare Pages
|
Size Change: +22 B (0%) Total Size: 482 kB
ℹ️ View Unchanged
|
mainframev
force-pushed
the
fix/modal-footer
branch
2 times, most recently
from
March 28, 2023 14:33
996aef3
to
c8bddd1
Compare
mainframev
force-pushed
the
fix/modal-footer
branch
from
March 28, 2023 14:39
c8bddd1
to
3b09732
Compare
DSil
previously approved these changes
Mar 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non blocking, but I'd add a test over a story to test the approach. Can be done separately, though
DSil
reviewed
Mar 28, 2023
mainframev
force-pushed
the
fix/modal-footer
branch
from
March 28, 2023 19:44
e87d4af
to
830dd7d
Compare
mainframev
force-pushed
the
fix/modal-footer
branch
from
March 28, 2023 21:41
830dd7d
to
dcd1254
Compare
DSil
approved these changes
Mar 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
mainframev
added a commit
that referenced
this pull request
Apr 17, 2023
* fix(ModalFooter): count children properly * chore: fixes after review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is quite the same as we had before inside
Itinerary
when conditions were falsy and it was still counting it withReact.Children.count
, there are several ways how to fix it, filter the nodes withReact.isValidElement
and leftReact.Children.count
or useReact.Children.toArray(children).length