New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tokens): fix bundle tokens definitons #3940
Conversation
Deploying with Cloudflare Pages
|
Size Change: +174 B (0%) Total Size: 493 kB
ℹ️ View Unchanged
|
chore: version bump for tokens package chore(tailwind): update tokens package and fix tests
f78d20d
to
792e0e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Pipeline is failing because it is missing the class definition for the new palette colors on backgroundColor
and color
under common/tailwind
files. This ensures we always support all colors for the palette tokens we have defined 🙂
Building the components package will also update the types for Box and Separator props, as they accept all palette colors
Yeah, already fixing this 💪🏻 |
c27edff
to
d31a16b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't Box and Separator types be updated on this PR as well?
I also feel the second commit message should not be a fix, as I don't think it's something worth mentioning on the changelog (the first commit already covers the fix, imo)
d31a16b
to
bf4ff8c
Compare
I will still squash it |
Slack request. Some typos during the definition of button deprecated tokens.