Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stripe library (urlfetch) just waits with block_network #23

Closed
daaain opened this issue Nov 19, 2019 · 2 comments
Closed

Stripe library (urlfetch) just waits with block_network #23

daaain opened this issue Nov 19, 2019 · 2 comments

Comments

@daaain
Copy link

daaain commented Nov 19, 2019

Hey,

Thanks a lot for this library!

I managed to get everything working, except that when I run our test suite with block_network it just waits and nothing happens.

VCR functionality does work even if I don't pass the flag so I can run the tests with recorded network communication data, but it seems for some reason the Stripe library (using urlfetch apparently) just waits when the network is blocked.

I guess maybe #16 would solve this issue?

@Stranger6667
Copy link
Collaborator

Hello, thank you for using our library and reporting this issue :)

It heavily relies on the implementation - if, for example, there is some retry-on-error logic, then the flow could be stuck on this socket connection step and keep retrying and with some unfortunate circumstances it could last an indefinite period of time.

Could you, please, provide some minimum code sample from that Stripe library that fails with block_network? so we can have an initial direction where to look at

@Stranger6667
Copy link
Collaborator

Feel free to reopen this issue if the problem is still there. I hope that #16 will be implemented during this year's Hacktoberfest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants