Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More robust message for network access blocking #63

Open
thatguysimon opened this issue Oct 26, 2020 · 0 comments
Open

More robust message for network access blocking #63

thatguysimon opened this issue Oct 26, 2020 · 0 comments

Comments

@thatguysimon
Copy link

thatguysimon commented Oct 26, 2020

Hi!
It would be great to see a more robust error message than "Network is disabled".
This would be especially useful for newcomers or people who aren't aware that this package is installed on the project they are working on.

Some ideas for what it could contain:

  1. A title saying that the error is coming from this package
  2. A short summary of what happened. Why the error was raised.
  3. The http request that was made
  4. The list of configured allowed hosts (for quick comparison with the actual request made)
  5. Possible ways to solve the issue (change the request, record a cassette, add allowed hosts...)
  6. A link to the relevant section in the docs.

A great example of a similar error message is the message in Ruby's VCR implementation which you can see here: https://stackoverflow.com/questions/25799165/vcr-throwing-cant-handle-request-on-the-second-attempt-to-run-testfirst-attempt

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants