Skip to content
This repository has been archived by the owner on Mar 4, 2019. It is now read-only.

[Text Component] expo prop will not be enough #246

Closed
RobinCsl opened this issue Feb 13, 2019 · 1 comment
Closed

[Text Component] expo prop will not be enough #246

RobinCsl opened this issue Feb 13, 2019 · 1 comment

Comments

@RobinCsl
Copy link
Collaborator

In #239, I thought the problem would be solved entirely.

However, if we are using Text inside Button component within universal-components, then expo prop will be false by default. That means that Button component used in Expo will not show bold text as bold.

Discussing with @JoseDuSV, we believe that universal-components should read some configuration file and/or figure out if it's an Expo environment or not.

@JosefDuda
Copy link
Contributor

Expo detection will be probably cleanest solution. But I'm not sure if there is some feature that will allow us to accurately detect it. 🤔

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants