Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add string documentation #561

Closed
kelson42 opened this issue Nov 27, 2023 · 6 comments · Fixed by #628
Closed

Add string documentation #561

kelson42 opened this issue Nov 27, 2023 · 6 comments · Fixed by #628
Assignees
Labels
Milestone

Comments

@kelson42
Copy link
Contributor

kelson42 commented Nov 27, 2023

Using the language code qqq. This language should obviously not be put in the binary.

Here is an example:
https://github.com/wikimedia/wikipedia-ios/tree/main/Wikipedia/Localizations/qqq.lproj

@kelson42
Copy link
Contributor Author

kelson42 commented Jan 2, 2024

@tvision251 Any news here?

@BPerlakiH
Copy link
Collaborator

It has been explicitly excluded, here: https://github.com/kiwix/apple/blob/main/project.yml#L113-L115
similarly we have it excluded for custom apps.

@kelson42
Copy link
Contributor Author

kelson42 commented Jan 5, 2024

@BPerlakiH This is a special code for documentation only, see https://translatewiki.net/wiki/FAQ#Special_private_language_codes_qqq,_qqx. if @tvision251 is not able to do it, would you?

@BPerlakiH
Copy link
Collaborator

I am not sure what is left to do here to be honest.
Currently these qqq files are already handled, they are added to git, but not included in the build.
Is there something else that needs to be done ?

@amire80
Copy link

amire80 commented Jan 6, 2024

I'm not the project manager, but from the point of view of good localization practices, this project needs the actual documentation. There are more than 230 strings in Apple Kiwix, and only 4 of them were documented (by myself).

All the strings in the English file need a corresponding documentation string in the qqq file: what are the parameters (such as %@), where does this string appear, what happens when it's clicked (if it's a button or a link), what does it describe (if it's an adjective), next to which strings it appears, etc. This documentation is the single most helpful resource for the volunteer translators.

MediaWiki is a separate project, but many MediaWiki volunteer translators also translate Kiwix, and that project has a good document with guidelines for writing and documenting messages:
https://www.mediawiki.org/wiki/Help:System_message

Almost all the tips in that document are applicable to Kiwix.

Thanks!

@BPerlakiH
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: DONE
Development

Successfully merging a pull request may close this issue.

4 participants