-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish Xcode integration #609
Comments
@rgaudin What would be an better altenative approach?
@BPerlakiH Why?
Dependencies version should be explicit anyway. Readme should be fixed.
I prefer the secret for convenience, but if this approach is proven to be combersome, then lets hardcode it everywhere. In any case, this has to be fixed. @BPerlakiH Please treat ticket in priority. |
I've addressed these issues here: #610 The Development Team value. Yes, I think that can be removed from secrets, I do not think it is a priority atm. The team id value contained in the project file is only a default one, and can be overwritten both in the building, and later in the code signing process. For these reasons, I think it can be treated separately. The code signing part is really a separate step. It is so much separated, that in theory even a different team id can be used to sign the final app. I think, at the very end of the review process Apple even re-signs all the apps once more, before they make it to the App Store in their final form. Since we are about to update the code signing / releasing part of our process (to fastlane + match), I would like to leave this part for later. I will keep in mind that we should ideally have a single source of truth for the value of the team id, if that's possible. |
LIBKIWIX-VERSION
environ on those files that makes it look like it controls the version used while it doesn't anymore.DEVELOPMENT_TEAM
is not a secret value but it's part of the several values associated with signing. In all repos we need them, we store it as a secret for convenience: when updating signing params, everything's in the same place. Given it doesn't change when certificates are renewed, we should remove it from the secrets… but you need to remove it from the places that are looking for it (CI, CD).Reported at #606 (comment)
The text was updated successfully, but these errors were encountered: