Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Support Kiwix" item to menu #660

Closed
Popolechien opened this issue Feb 20, 2024 · 18 comments · Fixed by #705 or kiwix/kiwix-apple-custom#62
Closed

Add "Support Kiwix" item to menu #660

Popolechien opened this issue Feb 20, 2024 · 18 comments · Fixed by #705 or kiwix/kiwix-apple-custom#62

Comments

@Popolechien
Copy link
Member

Popolechien commented Feb 20, 2024

Our Android App has a Support Kiwix element in its hamburger menu. Android-related donations constitute about a quarter of all the support we receive from individual users.

Can we please add a similar link to https://support.kiwix.org to the iOS app?

supportus (1)

@kelson42
Copy link
Contributor

kelson42 commented Feb 26, 2024

This also has to be customisable for custom apps. Need to find corresponding issue for Android because we have to do the same.

Here the README.md entry:

support_url, a URL, when it is set, it adds an Support app_name item to the sidebar app_name will be replaced with the actual app name. Clicking it opens the URL in an external web browser

@DobleV55
Copy link
Contributor

Hi there,

I've begun working on this project, and I want to make sure we're aligned on the button design. Could you please clarify your preference for the button style? I've attached an image with two options, but feel free to suggest any other alternatives that you might prefer.

Looking forward to your feedback!
frame

@Popolechien
Copy link
Member Author

Popolechien commented Mar 19, 2024

I'd favour option 2 but the wording should probably be "Support Kiwix" I guess. I would also suggest looking at other free apps (Signal?) that have similar donation prompts and see how they word it.

This might warrant a ticket of its own, but could we have the donation CTA rotate between 2-3 wordings (and links) so we can A/B test the most efficient ones?

@kelson42
Copy link
Contributor

kelson42 commented Mar 19, 2024

I'd favour option 2 but the wording should probably be "Support Kiwix" I guess.

Wording and way it works should be exactly like on android. Don't reinvent anything. @DobleV55 Let us know if you can not understand how it is on android.

@Popolechien
Copy link
Member Author

"Support Kiwix" it is then.

@DobleV55
Copy link
Contributor

Thank you for all your replies and feedback. Based on your input, I'll be replicating the 'Support Kiwix' button flow from Android.

@DobleV55
Copy link
Contributor

Hi 👋🏻 ,

While creating the button, I encountered the following issue: When clicking on a link or button with an external link, it works correctly the first time. However, upon clicking it a second time, it no longer functions unless you click on another link or button that directs to an external link.

Should I create an issue to address this?

support_kiwix_button.mp4

@Popolechien
Copy link
Member Author

yep, thanks for the video. Looks like a separate issue to me, so yes please open a new one (unless you have reasons to assume that your fix created the issue).

@kelson42
Copy link
Contributor

@BPerlakiH Can you please guide/help @DobleV55 ?

@DobleV55
Copy link
Contributor

DobleV55 commented Mar 20, 2024

Hi, apologies for the delayed response (I was asleep 😅). I'm in the UTC-3 timezone. I'll create the issue now and upload the PR with the completed "Support Kiwix" button.

@DobleV55
Copy link
Contributor

Apologies, this is my first time contributing to an open-source project. How do I upload the changes? I forked the project and created a branch, then pushed the changes there. However, I'm unsure if this is the correct procedure.

@BPerlakiH
Copy link
Collaborator

BPerlakiH commented Mar 21, 2024

Hi @DobleV55,
Thank you for the changes.
You can create a Pull Request here:
main...DobleV55:apple:660-add-supp…item-to-menu

From the changes, I can see that you can remove the "Brewfile.lock", those changes are not needed.
I will look into that, maybe we should add that file to .gitignore, to avoid confusions.

@BPerlakiH
Copy link
Collaborator

The "Brewfile.lock is addressed here"

@BPerlakiH
Copy link
Collaborator

Please do not hard code these colours as of your PR, the image should work without any modifier, while the text should work in both "Dark Mode" and "not Dark mode" as well (where the white text is not visible enough).

@DobleV55
Copy link
Contributor

Hi @BPerlakiH ,
Thank you for the feedback. I've updated the PR #705 to remove the hardcoding of colors. Now, the text should be visible in both "Dark Mode" and "Light Mode". Please feel free to let me know if there are any further adjustments required 🤗

@DobleV55
Copy link
Contributor

Hi,
Do you think this approach works well for the app?

supportios

@Popolechien
Copy link
Member Author

LGTM (except the colour part, I defer to @BPerlakiH for that one).

@DobleV55
Copy link
Contributor

The code for the mobile version of the "Support Kiwix" button has been uploaded. Please let me know if you think any modifications or additions are necessary, or if it is already somewhat finalized. Thank you very much ❤️

@rgaudin rgaudin linked a pull request Mar 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants