-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Support Kiwix" item to menu #660
Add "Support Kiwix" item to menu #660
Comments
This also has to be customisable for custom apps. Need to find corresponding issue for Android because we have to do the same. Here the README.md entry:
|
Hi there, I've begun working on this project, and I want to make sure we're aligned on the button design. Could you please clarify your preference for the button style? I've attached an image with two options, but feel free to suggest any other alternatives that you might prefer. |
I'd favour option 2 but the wording should probably be "Support Kiwix" I guess. I would also suggest looking at other free apps (Signal?) that have similar donation prompts and see how they word it. This might warrant a ticket of its own, but could we have the donation CTA rotate between 2-3 wordings (and links) so we can A/B test the most efficient ones? |
Wording and way it works should be exactly like on android. Don't reinvent anything. @DobleV55 Let us know if you can not understand how it is on android. |
"Support Kiwix" it is then. |
Thank you for all your replies and feedback. Based on your input, I'll be replicating the 'Support Kiwix' button flow from Android. |
Hi 👋🏻 , While creating the button, I encountered the following issue: When clicking on a link or button with an external link, it works correctly the first time. However, upon clicking it a second time, it no longer functions unless you click on another link or button that directs to an external link. Should I create an issue to address this? support_kiwix_button.mp4 |
yep, thanks for the video. Looks like a separate issue to me, so yes please open a new one (unless you have reasons to assume that your fix created the issue). |
@BPerlakiH Can you please guide/help @DobleV55 ? |
Hi, apologies for the delayed response (I was asleep 😅). I'm in the UTC-3 timezone. I'll create the issue now and upload the PR with the completed "Support Kiwix" button. |
Apologies, this is my first time contributing to an open-source project. How do I upload the changes? I forked the project and created a branch, then pushed the changes there. However, I'm unsure if this is the correct procedure. |
Hi @DobleV55, From the changes, I can see that you can remove the "Brewfile.lock", those changes are not needed. |
Please do not hard code these colours as of your PR, the image should work without any modifier, while the text should work in both "Dark Mode" and "not Dark mode" as well (where the white text is not visible enough). |
Hi @BPerlakiH , |
LGTM (except the colour part, I defer to @BPerlakiH for that one). |
The code for the mobile version of the "Support Kiwix" button has been uploaded. Please let me know if you think any modifications or additions are necessary, or if it is already somewhat finalized. Thank you very much ❤️ |
Our Android App has a
Support Kiwix
element in its hamburger menu. Android-related donations constitute about a quarter of all the support we receive from individual users.Can we please add a similar link to https://support.kiwix.org to the iOS app?
The text was updated successfully, but these errors were encountered: