Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading icon does not disappear if there is no internet connection #1856

Closed
Frans-Lukas opened this issue Mar 4, 2020 · 2 comments · Fixed by #1878
Closed

Loading icon does not disappear if there is no internet connection #1856

Frans-Lukas opened this issue Mar 4, 2020 · 2 comments · Fixed by #1878

Comments

@Frans-Lukas
Copy link
Contributor

Describe the bug

When in flightmode or without internet and going from the start screen/library to the 'Download books'/online view the loading icon will never disappear.

Expected behavior

If there is no internet connection the loading icon should not appear at all. Just the text saying that there is no internet connection.

Steps to reproduce the behavior:

  1. Enter flight mode or disable your internet connection.
  2. Open kiwix.
  3. Click on Download Books
  4. The loading icon will keep rotating with a message of 'No network connection.' until a connection is found and the zim metadata has been downloaded.

Screenshots

88138277_2939901259387784_7018593817183911936_n

88189311_994388140975906_7586015643309178880_n

Environment

  • Version of Kiwix Android : 3.2.1 Build: 6230201
  • Device : OnePlus 5
  • OS version : 9.0.10 OxygenOS
@kelson42 kelson42 added this to the 3.3 milestone Mar 5, 2020
@kelson42
Copy link
Collaborator

kelson42 commented Mar 5, 2020

Agree

@waahm7
Copy link
Contributor

waahm7 commented Mar 5, 2020

@kelson42 I would love to do this. Can you please assign this to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants