Fixed crashes occurring in Version 3.8.1 when opening ZIM files. #3678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* A user provided logs indicating that, during the attempt to open ZIM files, a crash occurred when stopping the TTS service. The logs revealed that, in the absence of any activity to stop the service, using `requireActivity()` resulted in an error and application crash. To address this issue, we replaced `requireActivity()` with `activity`. Now, if there is no activity present, using `activity` avoids the error that would lead to a crash.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3678 +/- ##
============================================
- Coverage 48.58% 48.57% -0.01%
Complexity 1090 1090
============================================
Files 285 285
Lines 10588 10588
Branches 1418 1418
============================================
- Hits 5144 5143 -1
Misses 4600 4600
- Partials 844 845 +1 ☔ View full report in Codecov by Sentry. |
|
@MohitMaliFtechiz Has the whole codebase been checked for this scenario? |
|
We don't need to check the whole codebase for this since our application is based on a single activity so the activity will never be null for this scenario. This will null in a situation where the application crashing and we are trying to start/stop the service. The user is still facing this issue so there is some other issue occurring on the user's device that crashes the application. because of this these logs are showing. #3600 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3600
requireActivity()resulted in an error and application crash. To address this issue, we replacedrequireActivity()withactivity. Now, if there is no activity present, usingactivityavoids the error that would lead to a crash.Waiting for the user's reply, and then we will mark this ready for review.