Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom apps versions should be time based #559

Closed
kelson42 opened this issue Nov 26, 2023 · 3 comments
Closed

Custom apps versions should be time based #559

kelson42 opened this issue Nov 26, 2023 · 3 comments
Assignees
Milestone

Comments

@kelson42
Copy link
Contributor

Custom apps versions should be the same as the content. For example 2023-11.

@kelson42 kelson42 added this to the 3.3.0 milestone Nov 26, 2023
@BPerlakiH
Copy link
Collaborator

Maybe it's possible to do so.
According to Apple docs (taken from create a new version docs):

version number
The version number (CFBundleShortVersionString) is a user-visible string that represents the bundle version with a required format of three period-separated integers (0-9).
Each integer provides information about the release in the format [Major].[Minor].[Patch]. For example, in 10.14.1, 10 is the major revision number, 14 is the minor revision number, and 1 is the maintenance release number. This string is used throughout the system to identify the bundle version and should match the version number you enter in App Store Connect.

We can think about how to squeeze in the date into that format (eg. maybe using [Major].[Minor] to hold the date).
Possible side effects: it would leave us with less space for updates in cases of:

  • update not related to the content itself (eg. 2023.11.1 + a bug fix would be => 2023.11.2, even if it's released 6 months later)
  • content updated more frequently than 1 month (eg 2023.11.1 + very same code but new content would also give => 2023.11.2)

@kelson42
Copy link
Contributor Author

kelson42 commented Dec 1, 2023

Agree with your proposal

@BPerlakiH
Copy link
Collaborator

It is address in the PR: kiwix/kiwix-apple-custom#9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: DONE
Development

Successfully merging a pull request may close this issue.

2 participants