Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove xcconfig from main project and custom projects #615

Closed
BPerlakiH opened this issue Jan 10, 2024 · 3 comments
Closed

Remove xcconfig from main project and custom projects #615

BPerlakiH opened this issue Jan 10, 2024 · 3 comments
Assignees

Comments

@BPerlakiH
Copy link
Collaborator

BPerlakiH commented Jan 10, 2024

It turned out we can simplify the app configuration by relying only on .plist file values, therefore we can remove the xcconfig files.

@BPerlakiH BPerlakiH self-assigned this Jan 10, 2024
@BPerlakiH
Copy link
Collaborator Author

Currently the xcconfig file was containing the final value for APP_STORE_ID, and it was used in custom apps for other values as well.
Each target (the Kiwix app, and each custom app) had its own Info.plist file and xcconfig.
It turned out that we can simplify this process with inlining the values required for both Kiwix app and custom apps into the info plist file, and we can remove all xcconfig files, as this way they won't be needed.
This simplifies the whole process.

@BPerlakiH
Copy link
Collaborator Author

BPerlakiH commented Jan 10, 2024

In order to achieve this both the kiwix/apple and the kiwix/kiwix-apple-custom repositories need to be updated.

@BPerlakiH
Copy link
Collaborator Author

Implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: DONE
Development

Successfully merging a pull request may close this issue.

1 participant