Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to display partially downloaded zim files ? #68

Open
mgautierfr opened this issue Dec 10, 2018 · 7 comments
Open

How to display partially downloaded zim files ? #68

mgautierfr opened this issue Dec 10, 2018 · 7 comments

Comments

@mgautierfr
Copy link
Member

When using the contentManager to download a file, a user select "All files" (who is actually "Remote files") and click on the download button of the zim he want to download.
The the download starts and the button is replaced with the download progression.

The question is how this currently downloading book is displayed in the contentManager.
It is probably ok to keep it in the "All files" section. But should we displayed it also in the "Local files" ?
When we quit and restart Kiwix, the downloads are resumed, but it is not easy to know what are the current download, we have to go to the "All files" section and search (or scroll) for the books to see the status.

This is somehow related to #59 and #54 who are real bugs but I would like to know how to handle the "Downloading books" to fix everything correctly at once.

@schoenbaechler have you a suggestion ?

@kelson42
Copy link
Collaborator

kelson42 commented Dec 14, 2018

@mgautierfr I would recommend to put them immediately at the start of the download in the local library AND remove them from the remote library. It seems to me to be the right approach.

@schoenbaechler
Copy link

schoenbaechler commented Dec 16, 2018

@mgautierfr @kelson42:

Thanks for bringing this up. It’s intended that “All files“ does exactly what it says: always show all available files. It doesn’t matter if it’s downloaded before. The only difference is, that the label says “Open“ instead of “Download“. This is to provide a holistic ZIM file catalog overview and to clearly indicate which books have been downloaded before.

Also, partial downloads should be listed in “All files“. If only partially downloaded, they feature the progress indicator from this screen, without the speed indicator.

I suggest to implement an additional “Downloads“ section to the filters on the left side to provide quick access to ongoing and partial downloads. When a file has been fully downloaded, it would then be listed under “Local files". How does that sound?

@mgautierfr
Copy link
Member Author

I suggest to implement an additional “Downloads“ section to the filters on the left side to provide quick access to ongoing and partial downloads. When a file has been fully downloaded, it would then be listed under “Local files". How does that sound?

Sounds good. I've just downloaded a big file, and for now it is lost in the "All files" list and is pretty complex to know what file is currently downloaded and what is the progress about them.

@jetownfeve21 what do you think about this ?

@jetownfeve21
Copy link
Contributor

It seems legit

@stale
Copy link

stale bot commented Nov 27, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Nov 27, 2019
@kelson42 kelson42 added this to TODO in Qt Library May 3, 2021
@stale stale bot removed the stale label Nov 28, 2021
@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@kelson42
Copy link
Collaborator

Now, the "All files" are only "Online files", but the problem of loosing oversight of the partial downloads is still there. I still believe putting them somehow at the top is one of the most practical solutions, but not 100% (in particular of the feasability)

@kelson42 kelson42 removed this from TODO in Qt Library Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants