Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have an automatic way to synchronize the source code with kiwix-js #11

Closed
mossroy opened this issue Jun 24, 2017 · 1 comment
Closed
Assignees

Comments

@mossroy
Copy link

mossroy commented Jun 24, 2017

Currently, the code of kiwix-js is duplicated here, with a few modifications.
Some of these code modifications are currently being applied upstream (in kiwix-js).
But there will still be some windows-specific modifications (like #4, or adding the BOM in UTF-8 files see kiwix/kiwix-js#266).

An idea would be to have a script here that does all the synchronization stuff.
I had a few ideas coming from the java ecosystem (ant for example), but choose a technology that you prefer, and that is more adequate to the Microsoft ecosystem.

It could take as a parameter :

  • a branch name
  • or a commit id
  • or a tag name

and would do the following :

  • download a zip of the source code of kiwix-js through a URL like https://github.com/kiwix/kiwix-js/archive/master.zip
  • unzip the necessary files locally, overwriting the existing ones
  • add the BOM header to the files that need it
  • apply some patches (using the diff file format, or any other method you like)

It's just a suggestion, there might be better ways to do that.

@Jaifroid
Copy link
Member

I think the code bases of each app are now too far apart to do this automatically, and we just have to use the traditional methods of backporting changes from one code base to another.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants