Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open all headings option is partially broken #132

Closed
Jaifroid opened this issue Jan 16, 2021 · 5 comments
Closed

Open all headings option is partially broken #132

Jaifroid opened this issue Jan 16, 2021 · 5 comments
Assignees
Labels
bug/non-critical fixed Fixed, awaiting publication in new apps
Milestone

Comments

@Jaifroid
Copy link
Member

The option to open all headings in an article only works in jQuery mode on recent ZIMs.

@kelson42
Copy link
Contributor

@Jaifroid A regression?

@Jaifroid
Copy link
Member Author

@kelson42 It's not a regression in the ZIM JavaScript, it is just a regression in my Kiwix JS Windows app! (It shouldn't be hard to fix.) This is a custom option in the app which allows the user to specify that headings should always be open. It is only broken in contexts where Service Worker is supported (PWA, Electron, NWJS), not in the main UWP app.

It would be nice if an option to open all headers no matter what the screen size were available as part of the planned API for Wikimedia ZIMs. However, if it is a niche case, it can continue to be handled in the reader(s).

@Jaifroid Jaifroid changed the title Open all headings option is broken in Service Worker mode Open all headings option is partially broken Jan 17, 2021
@Jaifroid
Copy link
Member Author

Partially fixed: it now works correctly in Service Worker mode. However, in jQuery mode, headings are ALWAYS open regardless of the setting in Configuration. Needs further work.

@Jaifroid
Copy link
Member Author

Now fixed in JQuery mode.

@Jaifroid Jaifroid added the fixed Fixed, awaiting publication in new apps label Oct 18, 2021
@Jaifroid
Copy link
Member Author

But not fully fixed in IE11. See #202.

@Jaifroid Jaifroid closed this as completed Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/non-critical fixed Fixed, awaiting publication in new apps
Projects
None yet
Development

No branches or pull requests

2 participants