Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain the position when going back an article #168

Open
Inbefortus opened this issue Jul 15, 2021 · 3 comments
Open

Retain the position when going back an article #168

Inbefortus opened this issue Jul 15, 2021 · 3 comments
Assignees
Milestone

Comments

@Inbefortus
Copy link

The preceding section should be maintained when going back and forth, otherwise you have to scroll back to where you were priorly each time, and that makes it in the long term inconvenient.

Screen_Recording_20210715-162048_Samsung.Internet.mp4
@Jaifroid Jaifroid added this to the Release 1.6.0 milestone Jul 15, 2021
@Jaifroid Jaifroid self-assigned this Jul 15, 2021
@Jaifroid
Copy link
Member

Thanks, @Inbefortus , I agree. It should "just work" in Service Worker mode, but it doesn't. 😒
In JQuery mode, it would simply be a case of storing the vertical scroll along with the history object, and restoring it on back. Not difficult in principle.

@mossroy
Copy link

mossroy commented Jul 18, 2021

In SW mode, it should indeed "just work". And it does with kiwix-js on Chromium and Firefox.
Could it be because the underlying browser engine is Edge Legacy?

@Jaifroid
Copy link
Member

@mossroy This is a bug with my code on Kiwix JS Windows. At some point there is a rogue scroll to top, and the reason for putting it in there is lost in the depths of time (maybe something to do with lazy image loading). I need to trace it, and it shouldn't be hard to fix. I think on Kiwix JS everything works as indended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants