Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The app should only offer to download media files when the controls have scrolled into view #75

Closed
Jaifroid opened this issue Apr 28, 2019 · 0 comments · Fixed by #305
Closed

The app should only offer to download media files when the controls have scrolled into view #75

Jaifroid opened this issue Apr 28, 2019 · 0 comments · Fixed by #305
Assignees
@Jaifroid
Labels
bug/non-critical enhancement
Milestone
Release 2.3.0

Comments

@Jaifroid
Copy link
Member

Currently the app offers to download a media file if there is one defined anywhere on the page. This is due to the code that was put in place for playing non-supported video files on mobile, but it also gets triggered for any mp4 or webm video in a normal article. This gets annoying!
@Jaifroid Jaifroid added this to the Release 1.0 milestone Apr 28, 2019
@Jaifroid Jaifroid self-assigned this Apr 28, 2019
@Jaifroid Jaifroid modified the milestones: Release 1.0.0, Release 1.1.0 Sep 21, 2020
@Jaifroid Jaifroid modified the milestones: Release 1.1.0, Release 1.2.0 Dec 3, 2020
@Jaifroid Jaifroid modified the milestones: Release 1.2.0, Release 1.3.0 Feb 13, 2021
@Jaifroid Jaifroid modified the milestones: Release 1.4.0, Release 1.6.0 Jul 11, 2021
@Jaifroid Jaifroid modified the milestones: Release 1.6.0, Release 1.8.0 Aug 19, 2021
@Jaifroid Jaifroid modified the milestones: Release 1.8.2, Release 2.0 Dec 4, 2021
@Jaifroid Jaifroid modified the milestones: Release 2.0.0, Release 2.1.0 May 30, 2022
@Jaifroid Jaifroid modified the milestones: Release 2.1.0, Release 2.2.0 Aug 30, 2022
@Jaifroid Jaifroid mentioned this issue Oct 29, 2022
Merged
Jaifroid added a commit that referenced this issue Oct 30, 2022
@Jaifroid
Only display download alert when medium is fetched #75 (#305)
56f7c89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jaifroid Jaifroid

Labels
bug/non-critical enhancement
Projects
None yet
Milestone
Release 2.3.0
Development

Successfully merging a pull request may close this issue.

Only display download alert when medium is visible kiwix/kiwix-js-pwa
1 participant
@Jaifroid