Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable directory picking with the HTMLInputElement: webkitdirectory property #1032

Closed
Jaifroid opened this issue Jul 8, 2023 · 2 comments · Fixed by #1131
Closed

Enable directory picking with the HTMLInputElement: webkitdirectory property #1032

Jaifroid opened this issue Jul 8, 2023 · 2 comments · Fixed by #1131
Milestone

Comments

@Jaifroid
Copy link
Member

Jaifroid commented Jul 8, 2023

This might best be done as part of the #656, as the fallback for directory picking. Without the File System Access API, it would only be a very small win, because the user would still have to pick the directory containing ZIM archives every time they open the app. It would only be faster when selecting a different ZIM during the same session.

@Jaifroid
Copy link
Member Author

Jaifroid commented Oct 9, 2023

As mentioned, this is really a sub-issue of #656, and it may be easier to work on it holistically, because it's nearly the same underlying code for the File System Access API, to which supporting webkitdirectory is a kind of footnote (but an important one, because it works in Firefox, in Edge Legacy, and a number of other places where FSA doesn't work). So I'll add some comments in #656.

@Jaifroid
Copy link
Member Author

Jaifroid commented Oct 9, 2023

@Rishabhg71

@Jaifroid Jaifroid added this to the v3.11 milestone Nov 1, 2023
@Jaifroid Jaifroid linked a pull request Nov 1, 2023 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant