Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a bookmarking system like in Kiwix Desktop #757

Open
Jaifroid opened this issue Aug 25, 2021 · 3 comments
Open

Provide a bookmarking system like in Kiwix Desktop #757

Jaifroid opened this issue Aug 25, 2021 · 3 comments
Milestone

Comments

@Jaifroid
Copy link
Member

As suggested by @knowledge-is-power here, it would be good to have a bookmark system in Kiwix JS and Kiwix JS PWA/Windows. It would require #280 or similar, and probably also depends on #656 to allow seamless switching between bookmarks in different ZIM archives in a folder (to which the user has given read permission).

@kelson42
Copy link
Collaborator

This should simply work through the Web Browser bookmarking system. Would be a bad idea IMO to redo something special here.

@Jaifroid
Copy link
Member Author

This should simply work through the Web Browser bookmarking system. Would be a bad idea IMO to redo something special here.

Agreed in principle, but unfortunately it doesn't work even in Service Worker mode. So we need to make it work, probably with #280. Even so, that would only work in Service Worker mode, which Firefox browser-extension users can't access. Plus there are other contexts where the browser's native bookmarking system is not available: PWA, mobile. Another solution is needed for these. That solution should be as close to the native browser system as possible, and should leverage its APIs where they are available.

@kelson42
Copy link
Collaborator

I would recommend to really try to secure we have proper URLs - which is I guess the main problem to get this working with the browser bookmark system. Then re-evaluate how important is that to provide a bookmark system for other use cases. Developing a simple bookmarking system is easy, but having a compeeting feature here will need a lot of work...

@Jaifroid Jaifroid added this to the v3.6 milestone Jan 31, 2022
@Jaifroid Jaifroid modified the milestones: v4.0, v4.1 Apr 22, 2023
@Jaifroid Jaifroid modified the milestones: v4.3, v4.4 Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants