Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

searchSuggestionsSmart() does not fallback to legacy mode if broken FT index #154

Closed
kelson42 opened this issue Jun 23, 2018 · 4 comments
Closed
Assignees

Comments

@kelson42
Copy link
Collaborator

We have the problem on Android that ZIM files are splitted and therefore FT index broken. This is not a goal to keep that situation, but this is what we have for now under certain circumstances.

In that situation, the suggestion system is totally broken, which means that searchSuggestionsSmart() of the libkiwix does not return anything - always. To my opinion, it should still work with the legacy mode, the one we had before the Xapian index has been embedded in the ZIM files.

For example:

$ split --bytes=2M wikivoyage_en_all_nopic_2018-06.zim wikivoyage_en_all_nopic_2018-06.zim
$ rm wikivoyage_en_all_nopic_2018-06.zim
$ kiwix-search --suggestion wikivoyage_en_all_nopic_2018-06.zim Paris
$

I should see at least a result for the "Paris" article.

@kelson42
Copy link
Collaborator Author

MIght be the same as kiwix/kiwix-tools#134

@mhutti1
Copy link
Contributor

mhutti1 commented Jun 29, 2018

I believe this is fine on kiwix-android.

@stale
Copy link

stale bot commented Nov 21, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@kelson42
Copy link
Collaborator Author

kelson42 commented Apr 3, 2021

We don’t recommend to split randomly ZIM files. Kiwix Android does not anymore. We have a proper zimsplit tools.

@kelson42 kelson42 closed this as completed Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants