Kiwix-serve does not (always) print title properly

[kelson42]

With https://download.kiwix.org/zim/stack_exchange/stackoverflow.com_eng_all_2018-08.zim, the title in the search bar print escaped %26 characters.

[Bhavnaharitsa]

I want to work on this issue

[kelson42]

@Bhavnaharitsa OK, you probably need here to secure the HTML proper encoding before printing.

[Bhavnaharitsa]

Where can I find the file for the html page ?

[mgautierfr]

The content of the taskbar (I suppose it is what @kelson42 call search bar) is generated depending of the actual page displayed.

The template is here : https://github.com/kiwix/kiwix-tools/blob/master/static/server/taskbar.html.part
The template is used in the introduceTaskbar function here : https://github.com/kiwix/kiwix-tools/blob/master/src/server/kiwix-serve.cpp#L161

However, @kelson42 may speak about the titles displayed in the search suggestions (when you start to type a search term). If this is the case, you will have to look elsewhere :

• The suggestion result is generated by the function handle_suggest (https://github.com/kiwix/kiwix-tools/blob/master/src/server/kiwix-serve.cpp#L449).
• Then it is the jquery autocomplete method (http://api.jqueryui.com/autocomplete/) that is used handle the completion of the field. The autocomplete is setup here by https://github.com/kiwix/kiwix-tools/blob/master/static/server/include.html.part.

This is also related to #205. You may want to also fix it while your working of the title displaying. (But please try to separate your submissions with separated PRs or, at least, separated commits)

[rgaudin]

Also affected by this. @kelson42's link not much useful and hardly visible on online library. Use inspector to reveal.

Character & is escaped to %26.

It seems to be a known issue given this line but it didn't fix it. At least with 2.1.0.

  content = replaceRegex(content, replaceRegex(zimTitle, "%26", "&"), "__ZIM_TITLE__");

[kelson42]

@rgaudin Yes, its an old problem which already have been tried to be fixed... I think this is in fact a bit more complex than what it looks like... but I don't remember why.

[ghost]

This issue was moved by kelson42 to openzim/sotoki#235.