Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kiwix-serve welcome page not optimised #538

Closed
kelson42 opened this issue Feb 13, 2022 · 9 comments · Fixed by kiwix/libkiwix#786
Closed

Kiwix-serve welcome page not optimised #538

kelson42 opened this issue Feb 13, 2022 · 9 comments · Fixed by kiwix/libkiwix#786

Comments

@kelson42
Copy link
Contributor

See:

5ABEFE45-9CD4-4FDE-AD01-D19B64ED4A81

The problem here is that we should be able to see 3 tiles in a row, not inly 2.

I believe the problem comes from the default margin left, which applies as well to the filters: this is too high. Or at least, it shoukd be able to be smaller.

@ankur12-1610
Copy link

@kelson42 I would like to work on this issue!

@kelson42 kelson42 changed the title Kiwix-serve welcom page not optimised Kiwix-serve welcome page not optimised Feb 15, 2022
@ankur12-1610
Copy link

See:

5ABEFE45-9CD4-4FDE-AD01-D19B64ED4A81

The problem here is that we should be able to see 3 tiles in a row, not inly 2.

I believe the problem comes from the default margin left, which applies as well to the filters: this is too high. Or at least, it shoukd be able to be smaller.

@kelson42 I could you specify at which particular media query did this happen? Cause it has the same layout as you want in my local host.

@kelson42
Copy link
Contributor Author

@ankur12-1610 Imade this screenshot with an ipad, give a try to the responsive mode of your browser.

@ankur12-1610
Copy link

ankur12-1610 commented Feb 17, 2022

@ankur12-1610 Imade this screenshot with an ipad, give a try to the responsive mode of your browser.

Ah! got it, @kelson42 I understood the issue and I know how to solve it, but the problem now is where are the CSS files, how kiwix-tools uses CSS, does it uses skin from another kiwix project or 😅

@kelson42
Copy link
Contributor Author

All in libkiwix

@ankur12-1610
Copy link

All in libkiwix

I've raised a PR, kindly review.
Thanks!

@kelson42 kelson42 modified the milestones: 3.3.0, 3.4.0 Jun 2, 2022
@juuz0
Copy link
Collaborator

juuz0 commented Jun 22, 2022

Can I take this?
Related to kiwix/libkiwix#585

@kelson42
Copy link
Contributor Author

@juuz0 yes, Îm not happy with current PR approach

@eroyee
Copy link

eroyee commented Jun 29, 2022

Sorry to jump on this late, but I've just had time to try 3.3.0, previously I was using a nightly build from June '21.

I believe this is related, but if you'd prefer me to raise a separate issue please say so; I feel the screen realestate that's taken up by the whitespace in the new 'square' tiles is also pertinent here. With the attached example above the whitespace between "From Wikiversity" to "EN" etc probably doubles the required vertical space for the tile.

In the earlier version there was little additional whitespace with the rectangular tiles, which I think made quite a difference with the number of tiles you could show - particularly with a small screen (although one could display three across, so I can't compare exactly).

If it were possible to either remove the whitespace, or pass an option for the earlier layout, maybe that could assist those wishing to display many zim files in a single window? I realise there's a category filter option that can reduce the number of tiles displayed, but this does involve the user more, and in some cases could be unnecessary.

Otherwise thanks for the new stackoverflow.com_en_all_2022-05.zip which addresses #463 👍

N.B. For two of the tiles above 'Wikixxx' is mentioned three times. Perhaps if the bottom right mention was removed, the language identifier placed say top right, and the linespace between the icon and "From xxx" reduced (and the resultant whitespace removed) this could improve efficiency with regard to screen utilisation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment