Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move kiwix-serve primitives to kiwix-lib #8

Closed
kelson42 opened this issue Dec 30, 2016 · 6 comments
Closed

Move kiwix-serve primitives to kiwix-lib #8

kelson42 opened this issue Dec 30, 2016 · 6 comments

Comments

@kelson42
Copy link
Contributor

kiwix-serve binary should only rely on kiwix-lib and not on libmicrohttpd, ctpp2, etc.

@kelson42 kelson42 changed the title Move kiwix-serve primitive to kiwix-lib Move kiwix-serve primitives to kiwix-lib Dec 30, 2016
@mgautierfr
Copy link
Member

For ctpp2 yes. libkiwix.pc should declare that it needs ctpp2 and it should just work.
But ctpp2 doesn't provide a pkg-config file, so we have to refind ourselves the dependency.
We have to provide a patch to ctpp2 do handle it (or at least have kiwix-builder create the libctpp2.pc file).

For libmicrohttpd, I'm not sure. libmicrohttpd is used only by kiwix-serve. I see no reason to this dependency in kiwix-lib.

@legoktm
Copy link
Member

legoktm commented Jan 6, 2017

Have we asked the ctpp2 upstream (http://ctpp.havoc.ru/en/faq.html) to provide a pkg-config file? If not, I think that would be a good idea.

@kelson42
Copy link
Contributor Author

@mgautierfr What is exactly the status on this? I think ctpp2 is now in kiwix-lib and we have decided to keep libmicrohttps in kiwix-serve so far. What is also the point regarding @legoktm's question?

@kelson42
Copy link
Contributor Author

kelson42 commented Jan 19, 2018

kiwix-desktop 2.0 will include the HTTP server feature, so we will have to do it in the next months. For ctpp2, maybe would have a look to a replacment kiwix/libkiwix#21.

@kelson42
Copy link
Contributor Author

This is also necessary for kiwix/kiwix-android#259

@kelson42
Copy link
Contributor Author

kelson42 commented May 1, 2018

This issue was moved to kiwix/libkiwix#138

@kelson42 kelson42 closed this as completed May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants