-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the generation of static files #814
Comments
I'm commenting your comment here
We are documenting libzim usage. We will not document git usage or gcc, or cpp.
Which files ? |
The problem is that the cacheid has to be updated and if you don't know about it you won't commit it. Actually in previous PR, it seems that only the test server has been updated with a new cacheid. Seems wrong to me. |
It is not related to git at all then. The cacheid is simply the first eight char of the sha1 sum. Git is no related to that, you don't have to commit generated file
How it seems wrong ? "Everything" is automatized. You don't have to compute anything to have libkiwix working. |
If the cacheid is generated at the compilation and should not be part of the source, then why it is part of |
Because it is part of the final files served by the server. And |
So, why |
Because you have to modify it and |
After this discussion, this is more clear to me what has to be documented. I just want to remind that if we would generate all the time a random cacheid, we would have avoid a bit of cmplexity and all this discussion. I keep thinking that current approach is over-enginered. |
@juuz0 @veloman-yunkan @mgautierfr So, what are exactly the instructions to run to update the |
@kelson42 How I currently do this:
|
@juuz0 Thank you for your feedback. It makes sense to do like that indeed. |
The way it work and what is expected from devs is not obvious. See #813
The text was updated successfully, but these errors were encountered: