Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI #21

Open
ieschalier opened this issue Jun 29, 2019 · 3 comments
Open

CI #21

ieschalier opened this issue Jun 29, 2019 · 3 comments
Assignees
Projects

Comments

@ieschalier
Copy link

ieschalier commented Jun 29, 2019

We can use Jest as the runner, already integrated and a good runner.

prerequisites

  • Clean project 馃Ч
    • Update eslint rules
    • Add prettier
  • eslint + prettier in pre-commit 馃
  • First tests 馃
@ieschalier ieschalier self-assigned this Jun 29, 2019
@ieschalier ieschalier added this to Backlog in MVP Jun 30, 2019
@ieschalier ieschalier moved this from Backlog to In progress in MVP Jun 30, 2019
@nrcaz
Copy link

nrcaz commented Jul 5, 2019

Je veux bien le faire, j ai jamais mis ca en place. Je commence par ou ? :p

@ieschalier
Copy link
Author

Tout les pr茅s-requis 馃槈.

Un bon clean du projet car il y a pas mal de remont茅 d'eslint.

Ajout de prettier : https://prettier.io/docs/en/install.html. Faudra configurer un peut pour qu'il tourne bien avec eslint.

Pour le pre-commit on vois 莽a quand tout le reste seras OK.

@ieschalier
Copy link
Author

Si on veux run 莽a avec les github action faut s'inscrire car c'est en b茅ta pour l'instant.

Un admin doit faire un tour ici : https://github.com/features/actions 馃槈 ... @Vinksyunit ? 馃樃

@ieschalier ieschalier assigned nrcaz and ieschalier and unassigned ieschalier Jul 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MVP
  
In progress
Development

No branches or pull requests

2 participants