Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using 3.5.0 (gradle-5.4.1), you must import time lib too, not just time-android #10

Closed
KushtrimPacaj opened this issue Oct 1, 2019 · 4 comments

Comments

@KushtrimPacaj
Copy link

KushtrimPacaj commented Oct 1, 2019

Just updated an older project where I was using this library to Android Gradle Plugin 3.5.0 ( gradle wrapper dist gradle-5.4.1 ).
Initially I was just using implementation 'com.github.kizitonwose.time:time-android:1.0.2' as instructed in the readme, and it was working.

After update, there were many errors ( e.g. extension functions on Int like .seconds were on red - not found ). Weirdly the time:1.0.2 classes somehow aren't in classpath anymore .
The workaround solution was to add time:1.0.2 as direct dependency of the project, but it should be checked what did 3.5.0 break.

I'll give it a shot on fixing and make a PR when I have some free time

@atdan
Copy link

atdan commented Oct 16, 2019

I am having the same issue, please can you explain how you worked around it?

@KushtrimPacaj
Copy link
Author

Add time and time-android as direct dependency:

implementation 'com.github.kizitonwose.time:time:1.0.2'
implementation 'com.github.kizitonwose.time:time-android:1.0.2'

@atdan
Copy link

atdan commented Oct 16, 2019

It seems to have been fixed in implementation 'com.github.kizitonwose.time:time-android:1.0.3'

@KushtrimPacaj
Copy link
Author

Nice. I'll close this issue then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants