Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to use a function output as an input on a PID Controller, unless i remove this piece of validation #1165

Closed
huntj88 opened this issue Mar 25, 2022 · 3 comments
Closed

Unable to use a function output as an input on a PID Controller, unless i remove this piece of validation #1165

huntj88 opened this issue Mar 25, 2022 · 3 comments
Labels
bug Fixed and Committed

Comments

@huntj88
Copy link
Sponsor Contributor

huntj88 commented Mar 25, 2022

Describe the problem/bug

PID controllers include functions in the drop down menu, but it errors out with "A valid Measurement is required". If i remove this piece of validation code everything works as expected

huntj88@9e6317a
kizniche added a commit that referenced this issue Mar 25, 2022
@kizniche
Fix PIDs using Functions as measurement (#1165), fix saving Function …
fe51be8 
…Measurements
@kizniche
Copy link
Owner

Thanks for the bug report. I just pushed a fix.

@huntj88
Copy link
Sponsor Contributor Author

huntj88 commented Mar 25, 2022

Just tested, works for me 👍

@huntj88 huntj88 closed this as completed Mar 25, 2022
@kizniche
Copy link
Owner

This issue has been mentioned on Radical DIY Forum. There might be relevant details there:

https://forum.radicaldiy.com/t/mycodo-v8-13-0-release/820/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixed and Committed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kizniche @huntj88