Graph display ignores custom colours

[drgrumpy]

Version 8.3

Custom colours seem to be ignored and replaced with another colour.

Custom colours checkbox is checked and I select various colours for outputs, pid settings etc.
click save, then some of the colours seem to get changed...
I think it only affects outputs.....(i.e. inputs seem to keep their assigned colours)

[drgrumpy]

This is in the dashboard.

[drgrumpy]

See screenshot in #759 where the colours of the outputs are not the same as those that I selected.

[kizniche]

I can't replicate this behavior. Can you supply screenshots of both your graph as well as your configuration for that graph?

[drgrumpy]

This is before saving:

[drgrumpy]

This is after saving the above colour settings...

SSR1 should be red, but has taken the colour above....
Lights is red but should be pale yellow
PWM should be blue but is pale yellow..
I am wondering if there is a for loop that is indexed incorrectly ?

[drgrumpy]

And if I make a change to another value (like changing data grouping) and save again then I get another change to the colours....

[kizniche]

The issue is the ordering. The colors are correctly being applied to the graph series in the exact same order as in the configuration, however PIDs come before Outputs in the configuration and PIDs come after Outputs in the graph series.

[kizniche]

Fixed the order, now working on another issue: displaying the proper color from the database on the configuration page.

[kizniche]

Found the last issue and pushed fixes. They'll be available in the next release.

[drgrumpy]

Great, many thanks.