Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hall effect flow sensor - Cant save pulses per liter value #952

Closed
nagol10h opened this issue Mar 15, 2021 · 1 comment
Closed

Hall effect flow sensor - Cant save pulses per liter value #952

nagol10h opened this issue Mar 15, 2021 · 1 comment

Comments

@nagol10h
Copy link

problem/bug

After upgrading Mycodo to version 8.9.0(and then 8.9.1) I was looking forward to using the generic hall effect flow sensor input
The input works great except the pulses per liter number will not save a new value so it stays at 1 pulse per liter after saving.

I have tried several system restarts as well as back and front end restarts with no change in results.
This issue is the same for Mycodo 8.9.0 and 8.9.1

The flowmeter input functions normally just with a large flow showing due to the 1 pulse per liter setting that cannot be changed.
I can do a function to recalculate to actual liters as a workaround but wanted to raise the issue because I have not seen it brought up yet.

I really enjoy the software!

Versions:

Reproducibility

Deactivate flow meter input
Change pulses per liter to appropriate conversion number (450 for my flow sensor)
Save input

Expected behavior

Input is saved with new pulse per liter setting(450)

Instead input remains at 1 pulse per liter (default setting)

kizniche added a commit that referenced this issue Mar 15, 2021
…stom Actions (#952), set w1thermsensor==2.0.0 in Input dependencies, fix function reference
@kizniche
Copy link
Owner

The value is actually being saved to whatever you set, but it's erroneously displaying the default 1.0 value on the frontend. I just pushed a fix to display the correct value. This issue affected both Inputs and Outputs that had Custom Actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants