Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch sampling utility #26

Closed
kjappelbaum opened this issue Oct 17, 2020 · 1 comment · Fixed by #33
Closed

Batch sampling utility #26

kjappelbaum opened this issue Oct 17, 2020 · 1 comment · Fixed by #33
Assignees

Comments

@kjappelbaum
Copy link
Owner

Expected Behavior

In dispersant_screener we had the batch sampling argument in the pal function. There should be an easy way to do the same here.

Actual Behavior

Here, I didn't implement it as it simply means that the sample function needs to be run n times.

Options

  • refactor the sampling function to also take the number of samples
  • add a utility/wrapper function
@kjappelbaum kjappelbaum self-assigned this Oct 17, 2020
@kjappelbaum kjappelbaum mentioned this issue Oct 17, 2020
11 tasks
@kjappelbaum
Copy link
Owner Author

There's actually a design issue that I forgot:

  • we decided to update the mask array with the sampled points only in the update_train_set() function, which makes sense to me as before that the sampling didn't really happen. This is, a sample without subsequent measurement does not really help us and we do not know if only some or all objectives have been measured
  • for this reason, I suggest we implement exclude_idx in the _get_max_wt function such that we can exclude some indices in the case of batch sampling

@kjappelbaum kjappelbaum linked a pull request Oct 17, 2020 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant