Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement structuregraphs using rustworkx or graphtool #14

Open
kjappelbaum opened this issue Nov 1, 2022 · 0 comments
Open

Implement structuregraphs using rustworkx or graphtool #14

kjappelbaum opened this issue Nov 1, 2022 · 0 comments

Comments

@kjappelbaum
Copy link
Owner

kjappelbaum commented Nov 1, 2022

What inconvenient in the current implementation

  1. Slow. For large graphs, networkx is painfully slow. If one were to reimplement structure graphs I would reconsider this dependency.
  2. Double graph layer. At least in my use I quite often find myself working on graph.graph. Perhaps there should only be one ground truth for nodes and edges
  3. There is a link to the structure but it is not really clear what can mutate what (in fact, I think immutability would be much clearer)

What is convenient in the current implementation

There is a link to the structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant