Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codec tests and documentation needs to be updated #134

Closed
sethmlarson opened this issue Nov 1, 2022 · 1 comment · Fixed by #145
Closed

Codec tests and documentation needs to be updated #134

sethmlarson opened this issue Nov 1, 2022 · 1 comment · Fixed by #145

Comments

@sethmlarson
Copy link
Collaborator

sethmlarson commented Nov 1, 2022

Current tests and documentation in the README references the codec for this library as "idna" instead of "idna2008", should be updated. This value was changed in #131

This also makes me wonder if the test suite needs to test specific IDNA 2008 functionality since tests don't appear to be failing? cc @kjd

@kjd
Copy link
Owner

kjd commented Nov 1, 2022

I am exploring ways of addressing #128 and I am not sure this is the right approach yet. But yes, before this is pushed in a subsequent release it needs to line up with the documentation, and some covering tests need to be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants