Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support iOS13 darkmode ? #41

Closed
t0m0120 opened this issue Aug 30, 2019 · 8 comments
Closed

Support iOS13 darkmode ? #41

t0m0120 opened this issue Aug 30, 2019 · 8 comments

Comments

@t0m0120
Copy link

t0m0120 commented Aug 30, 2019

Hi, thanks for your great library

Do you have plans to support dark mode?

@KjellConnelly
Copy link
Owner

Not sure what darkmode has to do with rating. Can you elaborate what ideas you had, or APIs you are referring to?

@t0m0120
Copy link
Author

t0m0120 commented Sep 2, 2019

@KjellConnelly
Sorry for poor English

When I try dark mode on iOS 13 of Xcodebeta, the characters
are white but the background color remains white

スクリーンショット 2019-09-02 15 42 11

iOS Standard Alert etc. have a black background.
スクリーンショット 2019-09-02 15 48 33

@KjellConnelly
Copy link
Owner

I gotcha. That is an iOS issue which I'm sure will be resolved by Apple either before iOS 13 goes live, or soon after. This package uses their native API for that, so it'll be fixed as soon as they fix it. :)

@t0m0120
Copy link
Author

t0m0120 commented Sep 3, 2019

@KjellConnelly
I see
Thank you for checking

@gaauwe
Copy link

gaauwe commented Oct 16, 2019

Is there any update on this? I'm running the official iOS 13 now and I still get the white dialog while on dark mode

@KjellConnelly
Copy link
Owner

Probably still an issue if you've updated to the latest version of iOS. I suggest submitting a bug report to them. If they get enough, it'll make it more likely they fix it sooner rather than later.

@samitha9125
Copy link

@KjellConnelly Is this fixed now? Great library btw :)

@KjellConnelly
Copy link
Owner

Thanks! Though I haven't verified it myself, I did read a SO post from 2019 that says that it was fixed. So I assume it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants