Use SQLAlchemy on newer pandas versions #109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith pandas.read_sql
… older pandas versions
| @@ -27,12 +25,13 @@ def test_read_postgis_default(self): | |||
| sql = "SELECT * FROM nybb;" | |||
| df = read_postgis(sql, con) | |||
| finally: | |||
| if PANDAS_NEW_SQL_API: | |||
| # It's not really a connection, it's an engine | |||
| con = con.connect() | |||
There was a problem hiding this comment.
This repeated logic is horrible.
added 4 commits
July 11, 2014 16:11
|
This might help: travis-ci/travis-ci#2401 |
added 7 commits
July 11, 2014 22:37
…failing on Travis.
This reverts commit 5bdbd7b.
|
@jwass Thanks, I've tried every permutation I can think of, no luck with Aside: having a Travis-equivalent VM locally would be nice. |
|
Totally messed up the history here, closing in favor of #123. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses SQLAlchemy if running on pandas 0.14 or later, otherwise the DB API for connecting to postGIS.
Closes #98.