Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window.Open not triggering #41

Closed
NPC-NPC-NPC opened this issue Dec 29, 2021 · 2 comments
Closed

Window.Open not triggering #41

NPC-NPC-NPC opened this issue Dec 29, 2021 · 2 comments

Comments

@NPC-NPC-NPC
Copy link

I was not able to determine why, but window.open is not working for me. It never opens a new window/tab and then when window.close fires, the process ends.

I resolved this locally by adding the following instead of window.open

// @grant GM_openInTab

GM_openInTab (window.location.href);

This seems to also protect against the mentioned memory leak.

@rdespoiu
Copy link

rdespoiu commented Jan 2, 2022

Regarding the window.open not triggering on your end, it's possible your browser is just blocking that action. I found your issue post when I experienced this myself.

I removed the window.close() call and Chrome prompted me to allow/block window.open from executing on the Best Buy website. After I clicked allow, I had no more issues. Just wanted to leave this here in case anyone else runs into this, as the call to window.close() suppresses the browser notification.

@kkapuria3
Copy link
Owner

Have you turned on pop ups for bestbuy.com ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants