Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Fuzzy CompletionType option #323

Closed
Jacobious52 opened this issue Jan 24, 2020 · 1 comment
Closed

Feature Request: Fuzzy CompletionType option #323

Jacobious52 opened this issue Jan 24, 2020 · 1 comment

Comments

@Jacobious52
Copy link
Contributor

It would be neat and useful to have another CompletionType option that uses fuzzy searching, similar to functionality that provides fzf. I have a branch that uses skim to filter and select the completion as a proof of concept, but want to make sure this is a feature that would fit in rustyline. I imagine it would be an optional cargo feature as it adds more dependencies.

Here's an example using nushell which uses rustyline with my branch with fuzzy completion.
image

There's still some polish and some undesired behaviour, for example my current implementation adds a new line to the prompt. Not sure how to make it replace the existing line instead.

If this is a feature that would be useful, I'm happy to PR with some guidance on polishing the implementation.

This fuzzy search would also be useful for (reverse-i-search) mode, but I haven't gotten that far in the implementation yet.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants