ESM Support #163
Comments
|
Hi @shishkin , Thank you for your suggestion. It makes sense. The // package.json
{
"build": "microbundle src/index.mjs -f cjs,esm,umd && microbundle polyfill/polyfill.mjs -o polyfill/index.js -f cjs --no-sourcemap"
}However, I'm not sure if the package will work for Deno anyway because of the JSDom dependency which may not work for everywhere. Anyway, would you like to help with this improvement? |
|
I gave it a try but ultimately wasn't able to figure out dynamic imports in the isomorphic ESM case. After looking at In case of DOMPurify, the default export is an object with functions. And I wasn't able to construct a static export from dynamic imports as I wasn't able to unwrap promises without top level await. And top level await seems only supported on specific targets, so won't cover default ESM case. Please let me know if I have missed something. |
|
Thank you @shishkin for experimenting with this. If adding new formats doesn't help, there is no much I can help with. |
|
I also would like to know if ESM will be supported in the near future? DOMPurify now as Rollup build exposed with The import patch below helps for my unit tests to work in Jest (because Jest is still CJS, so import * as DOMPurify_ from 'dompurify';
const DOMPurify = ((DOMPurify_ as any)?.['default'] ?? DOMPurify_); // patch for rollup
async function initDOMPurifyWithJSDOM() {
const { JSDOM } = await import('jsdom');
const { window } = new JSDOM('<!DOCTYPE html>');
return DOMPurify(window);
}
function resolveDOMPurify() {
const isClientSide = typeof window !== 'undefined';
return isClientSide ? DOMPurify : initDOMPurifyWithJSDOM();
}To be honest, I didn't try the code yet with this project but I'm wondering if this approach would be acceptable to get ESM exports? The only downside is the JSDOM async import which might be a problem. Basically, this project is the only left as CJS only for my stack to be converted to be fully ESM, it would be great if |
Hi! I'm trying to use this package as a transitive dependency in Deno via esm.sh. Unfortunately
sanitizeis not a proper named export. I can't change the way this package is imported (e.g.import * as dompurify from "...") because it's a transitive dependency. What do you think about providing support for ESM natively?I see that
isomorphic-unfetchuses Node's conditional exports and provides separate browser,.cjsand.mjsimplementations. Maybe this could be done from a single source file and a tool like rollup to cross-build.cjsand.mjsformats.The text was updated successfully, but these errors were encountered: