Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary incompatibilty between 6.9.5_rev1 -> 6.9.2_rc2: reg_number_of_names #219

Closed
mtasaka opened this issue Oct 12, 2020 · 1 comment
Closed

Comments

@mtasaka
Copy link

mtasaka commented Oct 12, 2020

When compiling with --enable-posix-api on 6.9.5_rev1, and --enable-posix-api --enable-binary-compatible-posix-api, the symbol reg_number_of_names is removed, so this is binary compatible, because binary depending on oniguruma with using reg_number_of_names symbol provided by 6.9.5_rev1 can no longer find the symbol, and it will cause missing symbol error on runtime.

@@ -69,2 +69,3 @@
 onig_copyright	T
+onig_detect_can_be_slow_pattern	T
 onig_end	T
@@ -122,2 +123,3 @@
 onig_get_string_end_by_callout_args	T
+onig_get_subexp_call_limit_in_search	T
 onig_get_subexp_call_max_nest_level	T
@@ -167,2 +169,10 @@
 onig_positive_int_multiply	T
+onig_posix_reg_foreach_name	T
+onig_posix_reg_name_to_group_numbers	T
+onig_posix_reg_number_of_names	T
+onig_posix_reg_set_encoding	T
+onig_posix_regcomp	T
+onig_posix_regerror	T
+onig_posix_regexec	T
+onig_posix_regfree	T
 onig_reduce_nested_quantifier	T
@@ -212,2 +222,3 @@
 onig_set_retry_limit_in_search_of_match_param	T
+onig_set_subexp_call_limit_in_search	T
 onig_set_subexp_call_max_nest_level	T
@@ -313,3 +324,2 @@
 reg_name_to_group_numbers	T
-reg_number_of_names	T
 reg_set_encoding	T

	1 symbols removed
T reg_number_of_names

	11 symbols added
T onig_detect_can_be_slow_pattern
T onig_get_subexp_call_limit_in_search
T onig_posix_reg_foreach_name
T onig_posix_reg_name_to_group_numbers
T onig_posix_reg_number_of_names
T onig_posix_reg_set_encoding
T onig_posix_regcomp
T onig_posix_regerror
T onig_posix_regexec
T onig_posix_regfree
T onig_set_subexp_call_limit_in_search

6.9.6_rc2 changed reg_number_of_names to #define , but this is not okay for keeping binary compatibitify (this type of error happened on vim, for example), the library must export the symbol actually.

@kkos kkos closed this as completed in 43ec867 Oct 12, 2020
@mtasaka
Copy link
Author

mtasaka commented Oct 12, 2020

Confirmed fixed, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant