Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: investigate ethereum/tests for Kakarot #660

Closed
Eikix opened this issue Jul 26, 2023 · 4 comments
Closed

feat: investigate ethereum/tests for Kakarot #660

Eikix opened this issue Jul 26, 2023 · 4 comments
Assignees
Labels
timebox-3hrs Exploratory issue: Do not spend more than three hours on it to assess doability.

Comments

@Eikix
Copy link
Member

Eikix commented Jul 26, 2023

Exploration issue: we want to understand how to run ethereum/tests for Kakarot

  • is it at rpc level?
  • is it at the vm level?
  • how to handle state?
  • how do others do it? geth besu reth
@Eikix Eikix added the timebox-1hr Exploratory issue: Do not spend more than an hour on it to assess doability. label Jul 26, 2023
@Eikix Eikix assigned greged93 and jobez and unassigned greged93 Jul 26, 2023
@Eikix Eikix added timebox-3hrs Exploratory issue: Do not spend more than three hours on it to assess doability. and removed timebox-1hr Exploratory issue: Do not spend more than an hour on it to assess doability. labels Jul 26, 2023
@jobez
Copy link
Contributor

jobez commented Jul 26, 2023

Big picture flow of how projects consume the test against the vm level:

high level diagram

Some concrete examples across two projects:

We would want to do something like Mana, where we have a top level entrypoint that describes the categories of ethereum tests we want to use and be able to express which tests we expect to pass: https://github.com/mana-ethereum/mana/blob/master/apps/evm/test/evm_test.exs#L10

@Eikix
Copy link
Member Author

Eikix commented Jul 26, 2023

Alright! Great
About running these tests from the RPC node, what is the status?
I guess it'd not be so easy to load all of these JSON into Cairo,
It might be easier to trigger the tests using JSON-RPC?

In any case our next actionables are:

  • assess whether to run these tests directly on top of the VM (within kakarot repo) XOR run these tests at the RPC level (you mentioned retest? or smth)
  • create an epic issue that tracks all the steps in order to put in place those tests (basically the steps of your diagram)

@jobez
Copy link
Contributor

jobez commented Jul 26, 2023

KK, clarified my initial comment that this flow was for the VM case, now digging into how projects use https://ethereum-tests.readthedocs.io/en/latest/retesteth-ref.html

@Eikix
Copy link
Member Author

Eikix commented Jul 27, 2023

Are all the contents of this issue's comments encapsulated in https://www.notion.so/kakarotlabs/Ethereum-Tests-Research-680d13186ad94da397cdf19acffe7955 ?

If yes, I can close this and let you focus on Scroll

@Eikix Eikix closed this as completed Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
timebox-3hrs Exploratory issue: Do not spend more than three hours on it to assess doability.
Projects
Archived in project
Development

No branches or pull requests

3 participants