Configurable produce request version #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog.md
Outdated
| @@ -108,4 +108,6 @@ | |||
| * Support magic v2 batch/message format (message headers). | |||
| * Use rebar3 as primary build tool for travis-ci, erlang.mk is still supported. | |||
| * Support `SCRAM-SHA-256` and `SCRAM-SHA-512` SASL authentication mechanisms. | |||
| * 3.?.? | |||
There was a problem hiding this comment.
not planing to release it now.
will update when we decide to release.
zmstone
force-pushed
the
make-produce-api-vsn-configurable
branch
from
d114db5
to
0cfdd6d
Compare
k32
reviewed
Aug 1, 2018
src/brod_producer.erl
Outdated
| @@ -465,6 +477,16 @@ maybe_produce(#state{ buffer = Buffer0 | |||
| schedule_retry(State#state{buffer = Buffer}) | |||
| end. | |||
|
|
|||
| %% Resolve produce API version to use. | |||
| %% If api version is configured by user, always use configured vresion, | |||
Pull Request Test Coverage Report for Build 879
💛 - Coveralls |
zmstone
force-pushed
the
make-produce-api-vsn-configurable
branch
from
0cfdd6d
to
c5cf0a8
Compare
k32
approved these changes
Aug 1, 2018
k32
approved these changes
Aug 7, 2018
mikpe
approved these changes
Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.