Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix escript_incl_apps #318

Merged
merged 1 commit into from May 3, 2019
Merged

Fix escript_incl_apps #318

merged 1 commit into from May 3, 2019

Conversation

k32
Copy link

@k32 k32 commented May 3, 2019

Fixes #317

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1061

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.04%) to 79.375%
Files with Coverage Reduction New Missed Lines %
src/brod_kafka_apis.erl 1 75.0%
src/brod_client.erl 1 82.82%
src/brod_consumer.erl 1 74.44%
Totals Coverage Status
Change from base Build 1056: -0.04%
Covered Lines: 2032
Relevant Lines: 2560
💛 - Coveralls

@zmstone zmstone merged commit 12fdd47 into master May 3, 2019
@k32 k32 deleted the fix-brod-cli-incl-apps branch July 20, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmstone zmstone zmstone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix brod-cli
3 participants
@k32 @coveralls @zmstone