Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump kafka_protocol dependency #377

Merged
merged 1 commit into from Mar 27, 2020
Merged

Bump kafka_protocol dependency #377

merged 1 commit into from Mar 27, 2020

Conversation

k32
Copy link

@k32 k32 commented Mar 26, 2020

No description provided.

@zmstone
Copy link
Contributor

zmstone commented Mar 26, 2020

maybe 2.3.6 ?
kafka4beam/kafka_protocol#73

@coveralls
Copy link

coveralls commented Mar 26, 2020 •
edited

Pull Request Test Coverage Report for Build 1344

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 80.152%
Files with Coverage Reduction New Missed Lines %
src/brod_client.erl 1 85.45%
src/brod_group_coordinator.erl 1 87.99%
Totals Coverage Status
Change from base Build 1331: -0.07%
Covered Lines: 2217
Relevant Lines: 2766
💛 - Coveralls

@k32
Copy link
Author

k32 commented Mar 26, 2020

Hi! I haven't finished looking at the diffs in the affected repos yet... I can do another brod release shortly after the kafka_protocol PR is merged, if you wish to get these changes in brod ASAP.

@k32 k32 requested a review from a team March 26, 2020 14:55
@k32 k32 closed this Mar 27, 2020
@k32 k32 reopened this Mar 27, 2020
@k32 k32 merged commit a97154e into master Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikpe mikpe mikpe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@k32 @zmstone @coveralls @mikpe