Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle group_subscriber_v2 worker failures #406

Merged
merged 3 commits into from Jun 11, 2020
Merged

Handle group_subscriber_v2 worker failures #406

merged 3 commits into from Jun 11, 2020

Conversation

k32
Copy link

@k32 k32 commented Jun 9, 2020

Fixes #359

@coveralls
Copy link

coveralls commented Jun 9, 2020 •
edited

Pull Request Test Coverage Report for Build 1412

  • 12 of 14 (85.71%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 80.194%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/brod_group_subscriber_v2.erl 12 14 85.71%
Files with Coverage Reduction New Missed Lines %
src/brod_group_subscriber_v2.erl 1 85.56%
src/brod_kafka_apis.erl 1 76.0%
Totals Coverage Status
Change from base Build 1408: -0.02%
Covered Lines: 2235
Relevant Lines: 2787
💛 - Coveralls

@k32 k32 merged commit f9821eb into master Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikpe mikpe mikpe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement handler of 'DOWN' messages in group_subscriber_v2
3 participants
@k32 @coveralls @mikpe