Group subscriber v2 terminate #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1446
💛 - Coveralls |
mikpe
approved these changes
Jun 17, 2020
k32
force-pushed
the
group_subscriber_v2_terminate
branch
from
8fe8cf7
to
2d769c9
Compare
mikpe
reviewed
Jun 18, 2020
| @@ -70,9 +70,13 @@ | |||
| ]). | |||
|
|
|||
| %% Subscriber API | |||
| -export([ start_link_group_subscriber_v2/1 | |||
There was a problem hiding this comment.
nit: it's unfortunate that there's a _v2 in the name as the /1 arity makes it unambiguous. Maybe make the _v2 function a compat alias for start_link_group_subscriber/1, then drop the _v2 one when the old API is dropped?
There was a problem hiding this comment.
Not sure if I follow you here: brod_group_subscriber_v2:start_link/1 is an existing API that was introduced together with brod_group_subsriber_v2 behavior, so renaming it won't be BWC. I didn't add a similar new API for the old brod_group_subscriber module, because I consider it problematic, and I hope to get it removed in the next major release (and rename brod_group_subscriber_v2 module into brod_group_subscriber).
mikpe
approved these changes
Jun 18, 2020
k32
force-pushed
the
group_subscriber_v2_terminate
branch
from
86251a5
to
c30e5fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an optional
brod_group_subscriber_v2terminatecallback.