chore: adding basic example of usage in raw scenario + moving integration tests #299
Conversation
| @@ -72,6 +68,7 @@ | |||
| "husky": "^4.3.0", | |||
| "jest": "^26.4.2", | |||
| "lint-staged": "^10.4.0", | |||
| "npm-run-all": "^4.1.5", | |||
There was a problem hiding this comment.
Doesn't look like you're using this?
There was a problem hiding this comment.
@hardchor run-p command is part of it, will use it to run all scripts for examples (I will add more examples folders in future)
examples/basic/src/renderer/index.ts
Outdated
| const store = createStore(rootReducer, stateSyncEnhancer()) | ||
|
|
||
| const globalCounterEl = document.getElementById('globalCounter')! | ||
| document |
There was a problem hiding this comment.
What about placing these in a function like so
const registerEvents = () => {
...
}
...
render()
registerEvents()Just to add a bit of clarity.
examples/basic/package.json
Outdated
| @@ -0,0 +1,26 @@ | |||
| { | |||
| "name": "@electron-webpack-examples/basic", | |||
There was a problem hiding this comment.
Nitpick, but should this be @electron-redux-webpack-examples/basic?
There was a problem hiding this comment.
Oh, actually I didn't want webpack part here at all, must have included it by mistake, since it was giving me hard time :D It should be @electron-redux-examples/basic
|
🎉 This PR is included in version 2.0.0-alpha.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Instead of having single e2e test suite, that limits to one electron configuration, I have added examples directory, that will hosts multiple different usage scenarios (and integrations with external libs). On top of it, it will run integration suite on all the examples, so it will be easier to spot any potential integration mistakes, especially when dealing with middleware config