Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Redux Observable to handle async leads to actions being fired twice #67

Open
walleXD opened this issue Nov 15, 2017 · 3 comments
Open

Comments

@walleXD
Copy link

walleXD commented Nov 15, 2017

Hey,

I was trying to use redux-observable but the synchronous action which is fired by the async action gets fired twice.

For example, once I run increment_async action, which fires the increment action after 1000ms, the increment action is being fire twice. This only happens after setting up electron-redux

Any idea why that would be happening?

Thanks a bunch 🙏🏼

@walleXD walleXD changed the title Using Redux Observable to handle async leads to actions being fire twice Using Redux Observable to handle async leads to actions being fired twice Nov 15, 2017
@hardchor
Copy link
Contributor

Hey @walleXD

That's probably happening because your async action fires both on the renderer and the main thread. Have you tried aliased actions ?

@walleXD
Copy link
Author

walleXD commented Nov 22, 2017

I am just firing the actions in the renderer. Should I scope them with local to avoid being run twice?

Aliased actions allow us to fire the action in the main thread but this happens in the renderer but I didn’t try to use aliased action On the main thread with redux-observable. Will report back in my findings.

@hardchor
Copy link
Contributor

Yeah, so depending on what you're doing, your option is to either use the local option and prevent the action from being forwarded to the main thread's store, or use an aliased action to only trigger the action in the main store (which is the preferred way for actions that produce side-effects, e.g. AJAX requests etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants