Basic support for maintenance mode of mesos #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good to me, thanks for the PR |
|
Discovered a bug while testing with mesos, so now a small fix as I was interpreting wrong the DurationInfo in last commit. |
keis
reviewed
Apr 24, 2017
mesos/match.go
Outdated
| return nil | ||
| } | ||
|
|
||
| now := time.Now().UnixNano() |
There was a problem hiding this comment.
A bit of a nitpick but timestamps always puts my in worry about everything mode. So I think getting the current timestamp is better to do when we create the matcher (sent as an argument even) so the implementation can remain completely pure.
mesos/match_test.go
Outdated
| }, | ||
| }, | ||
| ) | ||
| offerE := offer("offer-c", 1.8, 512.0, |
There was a problem hiding this comment.
should be "offer-e" in the id-string
|
Thanks a lot @zmalik |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #163 the basic support to reject offers if the node is currently in maintenance window.