Skip to content
This repository has been archived by the owner on Jun 2, 2020. It is now read-only.

PHP7 support? #7

Closed
eirikhm opened this issue Nov 25, 2016 · 5 comments
Closed

PHP7 support? #7

eirikhm opened this issue Nov 25, 2016 · 5 comments

Comments

@eirikhm
Copy link

eirikhm commented Nov 25, 2016

https://developers.klarna.com/en/gb/kco-v3/download/php claims that PHP 7 is currently not supported, but all tests seems to pass.

What are the issues with PHP7? We are about to upgrade our servers to PHP7, so we need to have a clear plan for this.

@AndriusBartulis
Copy link

@eirikhm did you eventually move to PHP7? Did the SDK still work? Any issues?

@eirikhm
Copy link
Author

eirikhm commented Apr 25, 2017

Short answer: Yeah, seems to work well. We had some custom code which caused some issues, but that's being resolved. I encourage heavy testing ;-)

@eirikhm eirikhm closed this as completed Apr 25, 2017
@eirikhm eirikhm reopened this Apr 25, 2017
@tommiehansen
Copy link

I don't understand why PHP 5.x would work and PHP 7.x would not. What special depracated functions would be the cause to write that PHP 7.x is unsupported?

Also note that most depracated methods in PHP 5.6+ (released aug 2014...) also was depracated in 5.5+ meaning that it would be insane to use any of these in something released within the last 3 years basically. This in turn mean that PHP 7.x should work fine if the Klarna devs isn't insane. :)

@bubach
Copy link

bubach commented Aug 4, 2017

Started working on implementing this with PHP7 and so far no issues, except that the low Guzzle version requirement put me in dependency hell. (kludge fork with seemingly working Guzzle v6 support at https://github.com/Ridestore/kco_rest_php/)

I actually prefered the older SDK's custom (and thin) cURL wrappers. At least when you're not updating stuff for > 2 years.

@0x20h 0x20h mentioned this issue Jan 10, 2018
3 tasks
@mitemitreski
Copy link
Contributor

@bubach @tommiehansen @eirikhm @AndriusBartulis this is fixed in v3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants