Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monorepo structure #4

Closed
dogagenc opened this issue Sep 22, 2022 · 3 comments · Fixed by #5
Closed

Monorepo structure #4

dogagenc opened this issue Sep 22, 2022 · 3 comments · Fixed by #5

Comments

@dogagenc
Copy link
Contributor

dogagenc commented Sep 22, 2022

I've seen that you maintain multiple repositories for each library/framework. It's not necessary to make changes on each repo when you make updates/changes. This problem could be easily solved by using Lerna.

Project structure would be:

-- packages
  -- circum-icons-core
  -- circum-icons-svelte
  -- circum-icons-react
  -- circum-icons-vue

Lerna would deal publishing packages to proper npm registries.


Another idea:

Instead of creating and editing displayIcons.js file manually from svg files, you could write a build script that generates displayIcons.js file by extracting both names and direct inner html of svg files. So, it would be easy to add new icons just by adding files to svg folder and build circum-icons-core package.

@Klarr-Agency
Copy link
Owner

Klarr-Agency commented Sep 23, 2022

I didn't know Lerna, but that's really what I needed. I'll implement those two ideas for sure.

Can I ask you where did you find this repo :)

Thank you again for your time!

@Klarr-Agency Klarr-Agency linked a pull request Sep 24, 2022 that will close this issue
@dogagenc
Copy link
Contributor Author

I didn't know Lerna, but that's really what I needed. I'll implement those two ideas for sure.

Can I ask you where did you find this repo :)

Thank you again for your time!

Great! I think this two feature will help you to save your time for future. :)

We've created a browser extension called Designer Daily Report. I'm the main developer of it. I've seen your project in our Library section in Designer Daily Report. :)

@Klarr-Agency
Copy link
Owner

@dogagenc It looks really good! Again, thank you for your suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants