Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

viewBox sizes? #1

Closed
jurenovic opened this issue Jan 17, 2015 · 1 comment
Closed

viewBox sizes? #1

jurenovic opened this issue Jan 17, 2015 · 1 comment

Comments

@jurenovic
Copy link

Shouldn't viewBox be the same size as the icon declaration size.

If I use size="20" the render is:

<ng-md-icon icon="person" size="20">
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24" width="20" height="20"><path d="....."></path></svg>
</ng-md-icon>

I suppose it would be better:

<ng-md-icon icon="person" size="20">
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 20 20" width="20" height="20"><path d="....."></path></svg>
</ng-md-icon>

Thanks

@urmilparikh
Copy link
Contributor

Shape definitions of icons assume viewBox size of 24x24. I'm afraid setting viewBox to smaller size will crop icons and setting it to higher size will not scale them up.

Keeping viewBox to 24x24 and changing width & height seems to scale icons proportionately.

Let me know if you see a different behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants